SQL Injection in salesagility/suitecrm
Reported on
Feb 12th 2022
Description
In SuiteCRM v7.12.4, a malicious user can inject SQL query in order to affect the execution of predefined SQL commands impacting database leakage.
Proof of Concept
The $_POST['record'][1] parameter is controllable by a user and it is concatenated into SQL query [2] without validating them.
Source file: https://github.com/salesagility/SuiteCRM/blob/master/modules/ProspectLists/Duplicate.php#L62
$focus->retrieve($_POST['record']); //[1]
if (isset($_POST['isDuplicate']) && $_POST['isDuplicate'] == true) {
$focus->id='';
$focus->name=$mod_strings['LBL_COPY_PREFIX'].' '.$focus->name;
$focus->save();
$return_id=$focus->id;
//duplicate the linked items.
$query = "select * from prospect_lists_prospects where prospect_list_id = '".$_POST['record']."'"; // [2]
$result = $focus->db->query($query);
Impact
This vulnerability is capable of reading sensitive database related information such as read admin password hash and existing database data.
Occurrences
Hi Faisal,
Thank you for your Security Report(s).
We have raised this issue with our internal security team to be confirmed.
Below is a reference of the issue raised and ID allocated.
- SCRMBT-#188 - SQL Injection in Prospects List
We will review the issue and confirm if it is a vulnerability within SuiteCRM and meets our criteria for a Security issue. If an issue is not considered a Security issue or that it does not need to be private then we'll raise it via the GitHub bug tracker or a more appropriate place.
Thank you for your contribution to the SuiteCRM project.
Hi Faisal,
The Security Team have now assessed the following issue:
- SCRMBT-#188 - SQL Injection in Prospects List
This issue has been given a severity grading of 'Important'. Due to the severity of this issue we are working to release a fix for it very soon.
Once the fix is released, we aim to include your name in the release notes - giving credit for finding and reporting this issue. Please let us know if you would prefer not be included or have a specific request on how you would like to be referenced within the release notes.
Thank you for your assistance and contribution to the SuiteCRM product!
You can use the name in the release notes as
Faisal Fs with @faisalfs10x as handle, and company name NetbyteSEC, www.netbytesec.com.
Best wishes..
