Improper Access Control in liukuo362573/yishaadmin
Feb 10th 2022
https://www.github.com/liukuo362573/yishaadmin has an endpoint "/admin/File/UploadFile" that allows uploading files without authentication.
Server doesn't check user's permission when attacker access the endpoint. After that, server will directly call UploadFile function with the parameters provided by the attacker, leads to many information security risks.
Unauthenticated user can upload file to server. The server has performed file format check in UploadFile function, but attacker can continuously upload it, causing low of hard disk.
Note: The app allows for a maximum file upload of 5MB. Thus the attacker can upload 205 files to take up 1GB of storage. The simplest way to solve the issue is to implement authentication to avoid attacks from unauthenticated users.
Why don't you do the fix with the file at https://github.com/liukuo362573/YiShaAdmin/blob/master/YiSha.Web/YiSha.Admin.WebApi/Controllers/FileController.cs#L21?
Also, please review the 2 reports below as the patch is incomplete.