XSS Stored inside Standard Interface Help Link href attribute in glpi-project/glpi
Nov 3rd 2022
Cross-site scripting (XSS) is a type of security vulnerability that can be found in some web applications. XSS attacks enable attackers to inject client-side scripts into web pages viewed by other users.
The persistent (or stored) XSS vulnerability is a more devastating variant of a cross-site scripting flaw: it occurs when the data provided by the attacker is saved by the server, and then permanently displayed on "normal" pages returned to other users in the course of regular browsing, without proper HTML escaping.
In your application, XSS occurs when an administrator injects an XSS payload inside the
Standard Interface Help Link.
🕵️ Proof of Concept
Use an admin account to inject the Help link URL
Payload used :
Login into any accounts and try to visit the help page, the XSS will be executed !
XSS can cause a variety of problems for the end user that range in severity from an annoyance to complete account compromise.
Example of impacts :
- Disclosure of the user’s session cookie, allowing an attacker to hijack the user’s session and take over the account (Only if
HttpOnlycookie's flag is set to false).
- Redirecting the user to some other page or site (like phishing websites)
- Modifying the content of the current page (add a fake login page that sends credentials to the attacker).
- Automatically download malicious files.
- Requests access to the victim geolocation / camera.
- OWASP - Cross Site Scripting (XSS)
- OWASP - Cross Site Scripting Prevention Cheat Sheet
- Wikipedia - Cross-site scripting
- PortSwigger - Cross-site scripting
- Mozilla - Content Security Policy (CSP)
For XSS attacks to be successful, an attacker needs to insert and execute malicious content in a webpage. Each variable in a web application needs to be protected. Ensuring that all variables go through validation and are then escaped or sanitized is known as perfect injection resistance. Any variable that does not go through this process is a potential weakness. Frameworks make it easy to ensure variables are correctly validated and escaped or sanitised. In PHP, you can use the htmlspecialchars function to sanitize variables.
As a last line of defense, you can use Content Security Policy (CSP) to reduce the severity of any XSS vulnerabilities that still occur or Web Application Firewall (WAF).
To fix the vulnerability, you can use the function isValidWebUrl($url) from Toolbox.php.
Fixed by https://github.com/glpi-project/glpi-ghsa-qqqm-7h6v-7cf4/pull/1